Escape double quotes in all strings, not just top level model strings #20318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original fix for escaping double quotes in Custom HTTP Notifications fixed only top level strings in the model map. However, the backlog is a list of MessageSummary objects so the message.message fields were not properly being escaped. These changes add a
JsonSafeEngineProvider
which escapes all double quotes in String objects whenever they are substituted into a JSON formatted payload. This should handle all strings in the model, not just those that are top-level values.Motivation and Context
Graylog2/support#69
How Has This Been Tested?
local tests and unit tests
Screenshots (if appropriate):
Types of changes
Checklist: