Avoiding double encoding of query parameter.
#20314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
fix/avoid-double-url-encoding-for-query
branch
from
548f935
to
2889abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is fixing an issue with the pagination helper doing URL-encoding of the
queryparameter twice, effectively turningfoo barintofoo%2520baron the wire andfoo%20baron the receiving end.This most probably slipped in when
urijswas introduced in this piece of code, forgetting that it is already doing URL-encoding./nocl No user-facing change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: