Avoiding double encoding of query parameter. (#20314)

* Avoiding double encoding of `query` parameter. * Adding test case.
Graylog2 · Sep 2, 2024 · d365f46 · d365f46
1 parent 90dfad3
commit d365f46
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/graylog2-web-interface/src/util/PaginationURL.test.ts b/graylog2-web-interface/src/util/PaginationURL.test.ts
@@ -46,4 +46,10 @@ describe('PaginationUR', () => {
 
     expect(url).toEqual('https://foo/?page=1&per_page=10&bool=false&scope=scope-1&scope=scope-2&query=bar');
   });
+
+  it('should not URL-encode query parameter twice', () => {
+    const url = PaginationURL('https://foo', 1, 10, 'my search query');
+
+    expect(url).toEqual('https://foo/?page=1&per_page=10&query=my+search+query');
+  });
 });
diff --git a/graylog2-web-interface/src/util/PaginationURL.ts b/graylog2-web-interface/src/util/PaginationURL.ts
@@ -44,7 +44,7 @@ export default (destUrl: string, page: number, perPage: number, query?: string,
   }
 
   if (query) {
-    uri.addSearch('query', encodeURIComponent(query));
+    uri.addSearch('query', query);
   }
 
   return uri.toString();