Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drag events support in google-map-marker element #250

Merged
merged 2 commits into from
Jan 15, 2016
Merged

drag events support in google-map-marker element #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d670d8f
add drag events support to google-map-marker
naderio Jan 13, 2016
4de8611
demonstrate marker drag events, add tests, and include all elements i…
naderio Jan 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<google-map latitude="37.779" longitude="-122.3892" min-zoom="9" max-zoom="11"
language="en">
<google-map-marker latitude="37.779" longitude="-122.3892"
title="Go Giants!" draggable="true">
title="Go Giants!" draggable="true" drag-events>
<img src="https://upload.wikimedia.org/wikipedia/commons/thumb/4/49/San_Francisco_Giants_Cap_Insignia.svg/200px-San_Francisco_Giants_Cap_Insignia.svg.png" />
</google-map-marker>
<google-map-poly closed fill-color="red" fill-opacity=".25" stroke-weight="1">
Expand All @@ -50,6 +50,18 @@
function toggleControls() {
gmap.disableDefaultUi = !gmap.disableDefaultUi;
}

var marker = document.querySelector('google-map-marker');
var poly = document.querySelector('google-map-poly');
var point = document.querySelector('google-map-point');

marker.addEventListener('google-map-marker-dragend', function(e) {
var latLng = e.detail.latLng;
console.log('pin dropped', latLng.lat(), latLng.lng());
point.latitude = latLng.lat();
point.longitude = latLng.lng();
poly._buildPathFromPoints();
});
</script>
</body>
</html>
7 changes: 7 additions & 0 deletions google-map-elements.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<link rel="import" href="google-map.html">
<link rel="import" href="google-map-marker.html">
<link rel="import" href="google-map-marker.html">
<link rel="import" href="google-map-directions.html">
<link rel="import" href="google-map-search.html">
<link rel="import" href="google-map-point.html">
<link rel="import" href="google-map-poly.html">
40 changes: 39 additions & 1 deletion google-map-marker.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,21 @@
* @event google-map-marker-dblclick
*/

/**
* Fired repeatedly while the user drags the marker. Requires the dragEvents attribute to be true.
* @event google-map-marker-drag
*/

/**
* Fired when the user stops dragging the marker. Requires the dragEvents attribute to be true.
* @event google-map-marker-dragend
*/

/**
* Fired when the user starts dragging the marker. Requires the dragEvents attribute to be true.
* @event google-map-marker-dragstart
*/

/**
* Fired for a mousedown on the marker. Requires the mouseEvents attribute to be true.
* @event google-map-marker-mousedown
Expand Down Expand Up @@ -161,6 +176,15 @@
observer: '_clickEventsChanged'
},

/**
* When true, marker drag* events are automatically registered.
*/
dragEvents: {
type: Boolean,
value: false,
observer: '_dragEventsChanged'
},

/**
* Image URL for the marker icon.
* @type string|google.maps.Icon|google.maps.Symbol
Expand Down Expand Up @@ -269,6 +293,20 @@
}
},

_dragEventsChanged: function() {
if (this.map) {
if (this.dragEvents) {
this._forwardEvent('drag');
this._forwardEvent('dragend');
this._forwardEvent('dragstart');
} else {
this._clearListener('drag');
this._clearListener('dragend');
this._clearListener('dragstart');
}
}
},

_mouseEventsChanged: function() {
if (this.map) {
if (this.mouseEvents) {
Expand Down Expand Up @@ -380,7 +418,7 @@
});
this._contentChanged();
this._clickEventsChanged();
this._contentChanged();
this._dragEventsChanged();
this._mouseEventsChanged();
this._openChanged();
setupDragHandler_.bind(this)();
Expand Down
3 changes: 1 addition & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

</head>
<body>
<!-- FIXME rename sources to src,no multiple sources in iron-component-page yet-->
<iron-component-page sources='["google-map.html", "google-map-directions.html", "google-map-search.html"]'></iron-component-page>
<iron-component-page src="google-map-elements.html"></iron-component-page>
</body>
</html>
17 changes: 16 additions & 1 deletion test/marker-basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<google-map id="map1" latitude="37.77493" longitude="-122.41942">
<google-map-marker latitude="37.779" longitude="-122.3892"></google-map-marker>
<google-map-marker latitude="37.777" longitude="-122.38911"></google-map-marker>
<google-map-marker id="marker2" latitude="37.777" longitude="-122.38911" drag-events></google-map-marker>
</google-map>

<script>
Expand Down Expand Up @@ -75,6 +75,21 @@
});
});

test('dragEvents', function() {

var markerEl = Polymer.dom(map).querySelector('#marker2');

assert.equal(markerEl.dragEvents, true);

flush(function() {
assert.instanceOf(markerEl._listeners.drag, google.maps.MapsEventListener);
assert.instanceOf(markerEl._listeners.dragstart, google.maps.MapsEventListener);
assert.instanceOf(markerEl._listeners.dragend, google.maps.MapsEventListener);
done();
});

});

});

</script>
Expand Down