Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag events support in google-map-marker element #250

Merged
merged 2 commits into from
Jan 15, 2016

Conversation

naderio
Copy link
Contributor

@naderio naderio commented Jan 13, 2016

No description provided.

@naderio
Copy link
Contributor Author

naderio commented Jan 13, 2016

ok, will see

@naderio naderio force-pushed the master branch 2 times, most recently from 5f3ec9a to dcab968 Compare January 14, 2016 22:30
@naderio
Copy link
Contributor Author

naderio commented Jan 14, 2016

it doesn't make sense to recall _contentChanged again after _clickEventsChanged since the latter only attaches event listeners. anyhow, all 3 click events still work.
otherwise,

  • demo is updated to handle marker drag updating the polygon on the map
  • a test case that checks for drag events forward setup have been added
  • docs now show all elements instead of just google-map and google-map-marker

@ebidel
Copy link
Contributor

ebidel commented Jan 15, 2016

LGTM. Just a couple of more nits. Thanks for updating the page and docs.

@naderio
Copy link
Contributor Author

naderio commented Jan 15, 2016

all set

@ebidel
Copy link
Contributor

ebidel commented Jan 15, 2016

LGTM

ebidel added a commit that referenced this pull request Jan 15, 2016
drag events support in google-map-marker element
@ebidel ebidel merged commit eecb1cc into GoogleWebComponents:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants