Fix JavaScript errors in the demo (closes #43) #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the styling issue in #43 was caused by JavaScript errors on the page that were preventing the styles from fully loading.
I've update the code to work around these errors, but I'm a little concerned about the fact that they happened in the first place. Here's what happened:
options
property which broke the<google-analytics-chart>
element. Arguably this change shouldn't have been introduced without a major version bump for this exact reason.<google-analytics-dashboard>
, thequeryUpdated
event listener is getting called prior to thequery
property being initialized with its default value. I don't think this is WAI; it seems like it might be a bug in Polymer, though I don't have time to track down what may have caused the change in behavior.I'm happy to have these updates merged to fix the immediate styling issue, but if someone else has an answer to the second problem above, I think it would be better to figure out the source of the problem rather than merging in a temporary hack.