Skip to content

Commit

Permalink
Merge pull request #44 from philipwalton/bug-fixes
Browse files Browse the repository at this point in the history
Fix JavaScript errors in the demo (closes #43)
  • Loading branch information
ebidel authored Jun 23, 2016
2 parents 02c93b5 + c0520d1 commit a09d6c0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 2 additions & 0 deletions google-analytics-chart.html
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,8 @@

ready: function() {
this._boundResponseHandler = this.handleResponse.bind(this);

this.$.chart.options = this.$.chart.options || {};
merge(this.$.chart.options, getChartOptions(this.type), this.options);
},

Expand Down
6 changes: 5 additions & 1 deletion google-analytics-dashboard.html
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
},

ready: function() {
this.updateChildren();
this.updateChildren();
},

/**
Expand All @@ -91,6 +91,10 @@
* @param {CustomEvent} event - The event with the query data.
*/
queryUpdated: function(event) {
if (!this.query) {
this.query = {};
}

// Update `this.query` with the passed event data.
Object.keys(event.detail).forEach(function(key) {
this.query[key] = event.detail[key];
Expand Down

0 comments on commit a09d6c0

Please sign in to comment.