Use strict_types where appropriate
#12631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
added
P2
|
Plugin builds for 180f9cd are ready 🛎️!
|
|
Size Change: 0 B Total Size: 2.72 MB ℹ️ View Unchanged
|
swissspidy
reviewed
Nov 7, 2022
|
Surprised that there are only 3 test failures. They're related to #12631 (comment) but of course not PHPStan errors but PHPUnit test failures. This is a good reminder to myself that using To make the cast work & not cause PHPStan complaints, we'd have to do something like this in $tracking_id = $this->settings->get_setting( $this->settings::SETTING_NAME_TRACKING_ID );
return is_scalar( $tracking_id ) ? (string) $tracking_id : '';There are other instances of Needs a closer look & ideally tests. |
spacedmonkey
commented
Nov 10, 2022
swissspidy
reviewed
Nov 10, 2022
spacedmonkey
commented
Nov 10, 2022
spacedmonkey
commented
Nov 10, 2022
swissspidy
reviewed
Nov 11, 2022
includes/Settings.php
Outdated
| * | ||
| * @link https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php#L211-L267 | ||
| * | ||
| * @since 1.27.0 |
spacedmonkey
commented
Nov 14, 2022
spacedmonkey
commented
Nov 14, 2022
spacedmonkey
commented
Nov 14, 2022
swissspidy
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #9817