Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict_types where appropriate #9817

Closed
spacedmonkey opened this issue Nov 25, 2021 · 1 comment · Fixed by #12631
Closed

Use strict_types where appropriate #9817

spacedmonkey opened this issue Nov 25, 2021 · 1 comment · Fixed by #12631
Assignees
Labels
P2 Should do soon PHP Pull requests that update PHP code Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️

Comments

@spacedmonkey
Copy link
Contributor

Feature Description

Use strict types in PHP files that could reasonably support it.

declare(strict_types=1);

This would have to be classes we have full control of the typing and not one using filters.

Alternatives Considered

Additional Context

@spacedmonkey spacedmonkey added Type: Enhancement New feature or improvement of an existing feature PHP Pull requests that update PHP code Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Pod: WP & Infra labels Nov 25, 2021
@swissspidy swissspidy added the P3 Nice to have label Nov 25, 2021
@swissspidy swissspidy changed the title Use strict_types where appreciate Use strict_types where appropriate Feb 1, 2022
@swissspidy swissspidy added P2 Should do soon and removed P3 Nice to have labels Nov 4, 2022
@swissspidy
Copy link
Collaborator

Let's add it to all files, then see if there are any errors, and discuss.

@swissspidy swissspidy removed the Type: Enhancement New feature or improvement of an existing feature label Nov 4, 2022
@spacedmonkey spacedmonkey self-assigned this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Should do soon PHP Pull requests that update PHP code Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants