Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloud-monitoring-exporter)!: update to stable OTel metrics version #446

Merged
merged 6 commits into from
Nov 21, 2022

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Nov 19, 2022

Fixes #379
Fixes #129
Fixes #101

Lots of changes to upgrade to the latest (stable) version of OTel metrics.

I removed all of packages/opentelemetry-cloud-monitoring-exporter/test/transform.test.ts in favor of snapshot/golden tests I am adding in the next PR: #447.

Note codecov is failing because of the deleted tests

@aabmass aabmass force-pushed the metrics-exporter-latest branch from 6edbfb3 to 8c53490 Compare November 19, 2022 04:03
@aabmass aabmass force-pushed the metrics-exporter-latest branch 2 times, most recently from f0a1437 to a15f187 Compare November 19, 2022 04:25
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #446 (c4e8f58) into main (1c3c400) will decrease coverage by 5.92%.
The diff coverage is 64.38%.

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   95.83%   89.91%   -5.93%     
==========================================
  Files          12       12              
  Lines         432      446      +14     
  Branches       83       87       +4     
==========================================
- Hits          414      401      -13     
- Misses         18       45      +27     
Impacted Files Coverage Δ
...entelemetry-cloud-monitoring-exporter/src/types.ts 100.00% <ø> (ø)
...lemetry-cloud-monitoring-exporter/src/transform.ts 65.43% <53.48%> (-30.03%) ⬇️
...emetry-cloud-monitoring-exporter/src/monitoring.ts 87.36% <80.00%> (-2.22%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass aabmass requested a review from a team November 19, 2022 04:38
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@aabmass aabmass force-pushed the metrics-exporter-latest branch from a15f187 to a7fc619 Compare November 19, 2022 15:14
@aabmass
Copy link
Contributor Author

aabmass commented Nov 21, 2022

Going to merge with codecov checks failing since tests are added in the subsequent PRs

@aabmass aabmass merged commit 058b510 into GoogleCloudPlatform:main Nov 21, 2022
@aabmass aabmass deleted the metrics-exporter-latest branch November 21, 2022 17:04
@sam-throne sam-throne mentioned this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants