-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloud-monitoring-exporter)!: update to stable OTel metrics version #446
Merged
aabmass
merged 6 commits into
GoogleCloudPlatform:main
from
aabmass:metrics-exporter-latest
Nov 21, 2022
Merged
fix(cloud-monitoring-exporter)!: update to stable OTel metrics version #446
aabmass
merged 6 commits into
GoogleCloudPlatform:main
from
aabmass:metrics-exporter-latest
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
metrics-exporter-latest
branch
from
November 19, 2022 04:03
6edbfb3
to
8c53490
Compare
aabmass
force-pushed
the
metrics-exporter-latest
branch
2 times, most recently
from
November 19, 2022 04:25
f0a1437
to
a15f187
Compare
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 95.83% 89.91% -5.93%
==========================================
Files 12 12
Lines 432 446 +14
Branches 83 87 +4
==========================================
- Hits 414 401 -13
- Misses 18 45 +27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aabmass
commented
Nov 19, 2022
aabmass
force-pushed
the
metrics-exporter-latest
branch
from
November 19, 2022 15:14
a15f187
to
a7fc619
Compare
punya
reviewed
Nov 19, 2022
packages/opentelemetry-cloud-monitoring-exporter/src/monitoring.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-cloud-monitoring-exporter/test/monitoring.test.ts
Show resolved
Hide resolved
punya
approved these changes
Nov 21, 2022
Going to merge with codecov checks failing since tests are added in the subsequent PRs |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #379
Fixes #129
Fixes #101
Lots of changes to upgrade to the latest (stable) version of OTel metrics.
I removed all of
packages/opentelemetry-cloud-monitoring-exporter/test/transform.test.ts
in favor of snapshot/golden tests I am adding in the next PR: #447.Note codecov is failing because of the deleted tests