Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distribution and histogram metric support #101

Closed
nlehrer opened this issue Jun 24, 2020 · 3 comments · Fixed by #446
Closed

Add distribution and histogram metric support #101

nlehrer opened this issue Jun 24, 2020 · 3 comments · Fixed by #446
Assignees

Comments

@nlehrer
Copy link

nlehrer commented Jun 24, 2020

Only non-distribution (bool, int64, double, etc.) values are supported by the exporter at the moment. See this line of code for the relevant TODO and where support should be added (perhaps among other places).

@nlehrer nlehrer changed the title Add distribution metric support Add distribution and histogram metric support Jul 7, 2020
@nlehrer
Copy link
Author

nlehrer commented Jul 7, 2020

Check if a distribution without buckets is rejected by the API.

@coreyvan
Copy link

coreyvan commented May 3, 2022

Are histograms and distribution metric kinds supported now? I noticed that a fix got merged in as part of #125 but there's still this method that sets the MetricKind to UNSPECIFIED (which causes GCP to reject the metric descriptor) here:

function transformMetricKind(kind: OTMetricKind): MetricKind {
switch (kind) {
case OTMetricKind.COUNTER:
case OTMetricKind.OBSERVABLE_COUNTER:
return MetricKind.CUMULATIVE;
case OTMetricKind.UP_DOWN_COUNTER:
case OTMetricKind.OBSERVABLE_GAUGE:
case OTMetricKind.OBSERVABLE_UP_DOWN_COUNTER:
return MetricKind.GAUGE;
default:
// TODO: Add support for OTMetricKind.HISTOGRAM
return MetricKind.UNSPECIFIED;
}
}

@nlehrer
Copy link
Author

nlehrer commented May 3, 2022

It does seem from that code that it is still not supported but that it could be easy to complete the support. A new owner needs to be found for this issue since @TigerHe7 is no longer working on this project (neither am I).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment