Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Distributions #125

Merged
merged 13 commits into from
Sep 1, 2020

Conversation

TigerHe7
Copy link
Contributor

@TigerHe7 TigerHe7 commented Jul 24, 2020

Addresses: #101

Summary

Adding support for exporting OpenTelemetry Distribution and Histogram types as Cloud Monitoring API v3 Distributions

Tests

  • Tested manually with exporting to personal GCP project
  • Updated unit tests

@TigerHe7 TigerHe7 changed the title [WIP] feat: Add support for Distributions feat: Add support for Distributions Jul 24, 2020
@TigerHe7 TigerHe7 changed the title feat: Add support for Distributions feat: add support for Distributions Jul 24, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files          10       10           
  Lines         303      303           
  Branches       58       58           
=======================================
  Hits          287      287           
  Misses         16       16           
Impacted Files Coverage Δ
...entelemetry-cloud-monitoring-exporter/src/types.ts 100.00% <ø> (ø)
...lemetry-cloud-monitoring-exporter/src/transform.ts 98.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0865d1...60bfae5. Read the comment docs.

Copy link
Contributor

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as the histogram format is the same!

@aabmass aabmass merged commit 0c92cde into GoogleCloudPlatform:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants