Skip to content

Replaced body-parser from run/pubsub sample #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ace-n merged 1 commit into from
Apr 19, 2021
Merged

Replaced body-parser from run/pubsub sample #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion run/pubsub/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@ For more details on how to work with this sample read the [Google Cloud Run Node
## Dependencies

* **express**: Web server framework.
* **body-parser**: express middleware for request payload processing.
* **mocha**: [development] Test running framework.
* **supertest**: [development] HTTP assertion test client.
4 changes: 2 additions & 2 deletions run/pubsub/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
// [START cloudrun_pubsub_server_setup]
// [START run_pubsub_server_setup]
const express = require('express');
const bodyParser = require('body-parser');
const app = express();

app.use(bodyParser.json());
// This middleware is available in Express v4.16.0 onwards
app.use(express.json());
// [END run_pubsub_server_setup]
// [END cloudrun_pubsub_server_setup]

Expand Down
1 change: 0 additions & 1 deletion run/pubsub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"system-test": "mocha test/system.test.js --timeout=300000 --exit"
},
"dependencies": {
"body-parser": "^1.19.0",
"express": "^4.16.4"
},
"devDependencies": {
Expand Down