Skip to content

Conversation

@nischay30
Copy link
Contributor

Removed body-parser from run/pub- sub sample and used internal express.json functionality as this middleware is available in Express v4.16.0 onwards

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 19, 2021
@google-cla
Copy link

google-cla bot commented Apr 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 19, 2021
@nischay30
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 19, 2021
@nischay30
Copy link
Contributor Author

@nicoleczhu @ace-n , Would you be able to review this?

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 19, 2021
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 19, 2021
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@ace-n ace-n merged commit a97dcfd into GoogleCloudPlatform:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants