Skip to content

Conversation

@ricalo
Copy link
Member

@ricalo ricalo commented Oct 3, 2019

Updates README of the speech-to-speech sample with instructions that use the Functions Framework instead of the Functions emulator.

The speech-to-speech sample was updated to replace the Functions emulator in #1255.

This fixes #1500.

ricalo added 3 commits October 3, 2019 12:29
The Functions Framework requires Node.js version 10 or higher. This commit
updates the version of node in the `.nvmrc` file to **lts/Dubnium**, which
corresponds to version `10.13.0` at this time.
Replaces the instructions to use the (deprecated) Functions emulator with
instructions on how to use the Functions Framework instead.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2019
@ricalo ricalo changed the title Replaces outdated README that references the Functions emulator. Replaces outdated instructions that reference the Functions emulator. Oct 3, 2019
@ricalo ricalo requested a review from ace-n October 3, 2019 17:32
@ricalo
Copy link
Member Author

ricalo commented Oct 3, 2019

Requesting review from @ace-n for accuracy.

Note: There are two failing tests. However, it doesn't look like the errors are related to this PR. Let me know if there's anything to fix on my end.

@ricalo ricalo requested a review from fhinkel October 3, 2019 17:35
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 4, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 4, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 7, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 7, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Oct 7, 2019

ping @ace-n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speech to speech Readme is outdated

5 participants