Remove emulator + shims from testing samples #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ace-n
added
the
do not merge
googlebot
added
the
cla: yes
ace-n
force-pushed
the
deprecate-emulator
branch
from
fd26f0a to
35c64f4
Compare
fhinkel
reviewed
Apr 24, 2019
grant
reviewed
Apr 24, 2019
Contributor
grant
left a comment
grant
left a comment
There was a problem hiding this comment.
Reviewed. Main comments:
- The
delays seem like they are unnecessary and would produce flaky tests. Let's remove them.
added 6 commits
May 2, 2019 17:45
added 2 commits
June 5, 2019 19:00
grant
approved these changes
Jun 10, 2019
Contributor
grant
left a comment
grant
left a comment
There was a problem hiding this comment.
Seems fine to me.
Not sure why the tests are failing.
ace-n
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
added 7 commits
June 17, 2019 13:30
grant
approved these changes
Jun 19, 2019
Contributor
Author
|
Update 3: switched from Node's |
Contributor
Author
|
Looks like the unit + integration tests (in Increased the timeout for the (currently failing) system tests - we'll see if that helps. 🙂 |
added 14 commits
September 18, 2019 17:26
Contributor
Author
|
Pub/Sub system tests are failing - I suspect due to a Stackdriver logs delay. Tests pass locally, so no choice but to debug in prod. 😦 Update: they're passing now. Any failures are likely due to Stackdriver flakiness/latency spikes. |
ace-n
removed
the
do not merge
ace-n
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until:
cl/252452007--> cl/269449711 )@google-cloud/nodejs-repo-toolsfrom sample tests, as it's (AFAIK) primarily for our internal use.