Skip to content

refactor: Remove functions_tips_terminate_node8 #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grant merged 2 commits into from
Sep 18, 2019
Merged

refactor: Remove functions_tips_terminate_node8 #1483

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
367486d
refactor: Remove functions_tips_terminate_node8
grant Sep 16, 2019
e4d6fe7
Merge branch 'master' into grant-functions_tips_terminate_node8
grant Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions functions/node8/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,6 @@ const fetch = require('node-fetch');
// [END functions_background_promise_node8]
// [END functions_background_async]

/**
* HTTP Cloud Function (same signature as other Node runtimes)
*
* @param {Object} req Cloud Function request context.
* More info: https://expressjs.com/en/api.html#req
* @param {Object} res Cloud Function response context.
* More info: https://expressjs.com/en/api.html#res
*/
// [START functions_tips_terminate_node8]
const escapeHtml = require('escape-html');

exports.helloHttp = (req, res) => {
res.send(`Hello ${escapeHtml(req.query.name || req.body.name || 'World')}!`);
};
// [END functions_tips_terminate_node8]

// [START functions_tips_infinite_retries_node8]
/**
* Background Cloud Function that only executes within a certain time
Expand Down