refactor: Remove functions_tips_terminate_node8 #1483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
This unrelated test fails:
|
grant
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Contributor
Author
|
@ace-n PTAL. |
ace-n
approved these changes
Sep 18, 2019
Contributor
ace-n
left a comment
ace-n
left a comment
There was a problem hiding this comment.
LGTM if related tests pass.
Side note: we can probably remove the _node8 samples, now that Node 6 is on its own branch.
This was referenced Jun 19, 2022
This was referenced Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused and non-unique sample 1373.