Skip to content

Update dependency @google-cloud/speech to v3 #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fhinkel merged 1 commit into from
Jul 26, 2019
Merged

Update dependency @google-cloud/speech to v3 #1434

fhinkel merged 1 commit into from
Jul 26, 2019

Conversation

@fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Jul 26, 2019

No description provided.

@fhinkel fhinkel requested review from ace-n and grant as code owners July 26, 2019 18:48
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019
ace-n
ace-n approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass.

@fhinkel fhinkel added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2019
@fhinkel
Copy link
Contributor Author

fhinkel commented Jul 26, 2019 •
edited
Loading

Never mind, this doesn't fix anything.

@fhinkel fhinkel mentioned this pull request Jul 26, 2019
Closed
1 task
@fhinkel
Copy link
Contributor Author

fhinkel commented Jul 26, 2019

Fixes #1306

@fhinkel fhinkel merged commit ab9ecfc into master Jul 26, 2019
@fhinkel fhinkel deleted the speechImage branch July 26, 2019 23:28
@ninadhatkar ninadhatkar mentioned this pull request Dec 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grant grant Awaiting requested review from grant

1 more reviewer

@ace-n ace-n ace-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fhinkel @ace-n @kokoro-team