Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate DataProfileResult and DataQualityResult for Dataplex Datascans. #8593

Merged
merged 9 commits into from
Aug 16, 2023
Merged

Deprecate DataProfileResult and DataQualityResult for Dataplex Datascans. #8593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
73b0308
Deprecate profileresult and quality result
saurabh-net Aug 9, 2023
3a55837
Update version_5_upgrade.html.markdown
saurabh-net Aug 9, 2023
660b810
Update version_5_upgrade.html.markdown
saurabh-net Aug 9, 2023
f8445c2
Update deprecation message
saurabh-net Aug 9, 2023
b3844fb
Merge branch 'main' into saurabh-net-patch-1-1
saurabh-net Aug 10, 2023
278094a
Update Datascan.yaml
saurabh-net Aug 15, 2023
fabad44
Update version_5_upgrade.html.markdown
saurabh-net Aug 15, 2023
6eb7c65
Merge branch 'main' into saurabh-net-patch-1-1
saurabh-net Aug 15, 2023
e485d04
minor spelling fix
saurabh-net Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mmv1/products/dataplex/Datascan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ properties:
- !ruby/object:Api::Type::NestedObject
name: 'dataQualityResult'
output: true
deprecation_message: "dataQualityResult will be removed from Terraform output fields in 5.0.0"
description: |
The result of the data quality scan.
properties:
Expand Down Expand Up @@ -642,6 +643,7 @@ properties:
- !ruby/object:Api::Type::NestedObject
name: 'dataProfileResult'
output: true
deprecation_message: "dataProfileResult will be removed from Terraform output fields in 5.0.0"
custom_flatten: templates/terraform/custom_flatten/dataplex_datascan_ignore_profile_result.go.erb
description: |
The result of the data profile scan.
Expand Down
6 changes: 6 additions & 0 deletions mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,12 @@ These two unsupported fields were introduced incorrectly. They are now removed.

This unsupported field was introduced incorrectly. It is now removed.

## Resource: `google_dataplex_datascan`

### `dataQualityResult` and `dataProfileResult` output fields are now removed

`dataQualityResult` and `dataProfileResult` were output-only fields which listed results for the latest job created under a Datascan. These were problematic fields that are unlikely to be relevant in a Terraform context. Removing them reduces the likelihood of additional parsing errors, and reduces maintenance overhead for the API surface.

## Resource: `google_compute_router_nat`

### `enable_endpoint_independent_mapping` now defaults to API's default value which is `FALSE`
Expand Down