-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate DataProfileResult and DataQualityResult for Dataplex Datascans. #8593
Deprecate DataProfileResult and DataQualityResult for Dataplex Datascans. #8593
Conversation
Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's some conflicts to be resolved. Was the decision about not removing the fields from the yaml, but marked them with a deprecated flag?
We are planning to remove the fields, but we need to deprecate them first per the discussion here: #8583 (comment) |
Sounds good, adding @c2thorn as reviewer here for visibility. |
Let me update this to resolve the conflicts in a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the attribute is deprecation_message
, not deprecation
|
||
### `dataQualityResult` and `dataProfileResult` output fields are now removed | ||
|
||
`dataQualityResult` and `dataProfileResult` were output-only fields which listed results for the latest job created under a Datascan. This is unlikely to be relevant in a Terraform context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add something like "These were problematic fields that are unlikely to be relevant..."
To add more justification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Changed field to deprecation_message
2 similar comments
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccProjectIamPolicy_invalidMembers |
Rerun these tests in REPLAYING mode to catch issues
|
Deprecate DataProfileResult and DataQualityResult for Dataplex Datascans.
Part of hashicorp/terraform-provider-google#15448
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)