Deprecate DataProfileResult and DataQualityResult for Dataplex Datascans.

[saurabh-net]

Deprecate DataProfileResult and DataQualityResult for Dataplex Datascans.
Part of hashicorp/terraform-provider-google#15448

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataplex: deprecated the following `google_dataplex_datascan` fields: `dataProfileResult` and `dataQualityResult`

[modular-magician]

Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[hao-nan-li]

Looks like there's some conflicts to be resolved. Was the decision about not removing the fields from the yaml, but marked them with a deprecated flag?

[saurabh-net]

We are planning to remove the fields, but we need to deprecate them first per the discussion here: #8583 (comment)

[hao-nan-li]

We are planning to remove the fields, but we need to deprecate them first per the discussion here: #8583 (comment)

Sounds good, adding @c2thorn as reviewer here for visibility.

[saurabh-net]

Let me update this to resolve the conflicts in a bit.

[c2thorn]

I believe the attribute is deprecation_message, not deprecation

[c2thorn]

Can we add something like "These were problematic fields that are unlikely to be relevant..."
To add more justification?

[saurabh-net]

Done

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 10 insertions(+))
Terraform Beta: Diff ( 3 files changed, 10 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 10 insertions(+))
Terraform Beta: Diff ( 3 files changed, 10 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 10 insertions(+))
Terraform Beta: Diff ( 3 files changed, 10 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2951
Passed tests 2648
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccProjectIamPolicy_invalidMembers[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test