Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc to add logging bucket as sink destination #4176

Merged

Conversation

venkykuberan
Copy link
Contributor

@venkykuberan venkykuberan commented Oct 30, 2020

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

  docs updated to add logging bucket as sink destination

fixes hashicorp/terraform-provider-google#7590

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 11 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 4 files changed, 11 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=155252"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceIAMBetaWorkloadIdentityPool_basic|TestAccDataSourceSpannerInstance_basic|TestAccBigqueryDataTransferConfig|TestAccResourceGoogleProjectDefaultServiceAccountsBasic|TestAccResourceGoogleProjectDefaultServiceAccountsDisable|TestAccResourceGoogleProjectDefaultServiceAccountsDelete|TestAccResourceGoogleProjectDefaultServiceAccountsDeprivilege|TestAccOSLoginSSHPublicKey_osLoginSshKeyBasicExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=155335"

@venkykuberan venkykuberan requested review from c2thorn and removed request for c2thorn November 3, 2020 12:03
@c2thorn
Copy link
Member

c2thorn commented Nov 3, 2020

Just saw that you removed the review request. The changes LGTM, but if you want me to review again later, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_logging_project_sink supports destination log bucket
3 participants