google_logging_project_sink supports destination log bucket

[omelnyk1]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

It seems there are only 3 possible destinations for terraform resource google_logging_project_sin:

• storage bucket
• pubsub topic
• bigquery dataset

https://www.terraform.io/docs/providers/google/r/logging_project_sink.html#destination
In fact, we can configure other 3 destinations. Please find GCP console screenshot below:

It would be nice to support destination cloud loggin bucket.

New or Affected Resource(s)

• google_logging_project_sink

Potential Terraform Configuration

example sink will look up logs by filter and send it to logging bucket dbalogs (resource id logging.googleapis.com/projects/my-project/locations/global/buckets/dbalogs) in GCP project my-project:

resource "google_logging_project_sink" "this" {
  name                   = "example"
  destination            = "logging.googleapis.com/projects/my-project/locations/global/buckets/dbalogs"
  filter                 = "logName=projects/my-project/logs/cloudsql.googleapis.com%2Fpostgres.log"
}

References

https://cloud.google.com/logging/docs/export#sink-terms
https://www.terraform.io/docs/providers/google/r/logging_project_sink.html#destination

• #0000

[c2thorn]

The destination field supports any destination that the user provides. We don't do any validation against the field, so you should be able to provide log buckets as destinations currently.

We meant to update our documentation, but it looks like that fell through. @venkykuberan, can we update the docs stating that log bucket destinations are possible, and also add text stating that the user can set any destination they want?

[c2thorn]

To clarify, the API expects the destination bucket to be in this form: logging.googleapis.com/projects{project}/locations/{location}/buckets/{bucket}.

Looks like we should also support passing in a bucket id to the destination field by prepending "logging.googleapis.com/" to the id projects{project}/locations/{location}/buckets/{bucket}

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!