Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use explicit version in monitoring data sources #3540

Merged
merged 1 commit into from
May 20, 2020

Conversation

danawillow
Copy link
Contributor

As of #3490, we don't hardcode the version in the monitoring base path anymore because it has two different versions for GA products (v1 and v3)

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 3 deletions(-))

@slevenick slevenick self-requested a review May 20, 2020 16:48
@c2thorn c2thorn changed the title use expicit version in monitoring data sources use explicit version in monitoring data sources May 20, 2020
@danawillow danawillow merged commit 4540f9c into GoogleCloudPlatform:master May 20, 2020
@danawillow danawillow deleted the monitoring-fix branch May 20, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants