-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stackdriver dashboards resource #3490
stackdriver dashboards resource #3490
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 18 files changed, 656 insertions(+), 31 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 18 files changed, 656 insertions(+), 31 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This produced incorrect results here:
The version of monitoring resources is now being listed as the base URL.
I personally don't know if that matters, but it's the only issue / error I saw - if you are interested in fixing it, lmk and I'll review again. Otherwise, LGTM.
For sure it breaks the library for those resources - I just don't know if those resources are actually published or have users, or how hard it would be to fix those resources. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 18 files changed, 656 insertions(+), 31 deletions(-)) |
Fixed it! I'm going to go ahead and merge now since the conversion repo looks totally fine and good. I don't think they actually have users- CAI doesn't seem to support monitoring as one of the things you can do stuff with, so I don't think it really matters, but figured it was worth fixing anyway in case they want to do something with it later. |
Fixes hashicorp/terraform-provider-google#5124.
Release Note Template for Downstream PRs (will be copied)