Improve nanosecond timestamp support. #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- timeNanos is deprecated because the 53 bit mantissa used for doubles
does not have sufficient precision to represent the current time in
nanoseconds past the unix epoch (which currently requires 61 bits).
- instead, we now support formats with split seconds and nanoseconds:
- timestampSeconds, timestampNanos
- timestamp { seconds, nanos }
In both cases, the "seconds" part represents seconds since the unix epoch,
and the "nano" part is the nanosecond component only (0..999999999).
Managed VMs is using the latter, but it can only be ingested via
json/msgpack/etc, while the former is suitable for use in an in_tail regex.
This should be considered an interim solution until
fluent/fluentd#461 is resolved.
| if (record.has_key?('timeNanos')) | ||
| if (record.has_key?('timestamp') && | ||
| record['timestamp'].has_key?('seconds') && | ||
| record['timestamp'].has_key?('nanos')) |
There was a problem hiding this comment.
If a user wants to only use seconds can he make a config that will automatically set "nanos" to zero?
If not, then maybe treat unset "nanos" as 0?
There was a problem hiding this comment.
I debated that but decided not to - since this is an interim step I really only want people to use this if they have a need, and whole seconds can already be handled by the native fluentd "time" using time_format %s.
|
LGTM |
mr-salty
added a commit
that referenced
this pull request
May 12, 2015
Improve nanosecond timestamp support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeNanos is deprecated because the 53 bit mantissa used for doubles
does not have sufficient precision to represent the current time in
nanoseconds past the unix epoch (which currently requires 61 bits).
instead, we now support formats with split seconds and nanoseconds:
In both cases, the "seconds" part represents seconds since the unix epoch,
and the "nano" part is the nanosecond component only (0..999999999).
Managed VMs is using the latter, but it can only be ingested via
json/msgpack/etc, while the former is suitable for use in an in_tail regex.
This should be considered an interim solution until
fluent/fluentd#461 is resolved.