-
Notifications
You must be signed in to change notification settings - Fork 96
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve nanosecond timestamp support.
- timeNanos is deprecated because the 53 bit mantissa used for doubles does not have sufficient precision to represent the current time in nanoseconds past the unix epoch (which currently requires 61 bits). - instead, we now support formats with split seconds and nanoseconds: - timestampSeconds, timestampNanos - timestamp { seconds, nanos } In both cases, the "seconds" part represents seconds since the unix epoch, and the "nano" part is the nanosecond component only (0..999999999). Managed VMs is using the latter, but it can only be ingested via json/msgpack/etc, while the former is suitable for use in an in_tail regex. This should be considered an interim solution until fluent/fluentd#461 is resolved.
- Loading branch information
Showing
2 changed files
with
24 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7652c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes fluentd to crash in record processing when someone has innocent timestamp field.
Line 171 causes:
2015-06-25 08:33:15 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-06-25 08:33:22 +0000 error_class="NoMethodError" error="undefined method `has_key?' for 1435221182.562538:Float" plugin_id="object:3feb02398820"
And as a result all data is lost. Please fix.
c7652c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #20 (pending review)