Allow bypassing OT Chromium checks in non-prod environments #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleJu
reviewed
Jan 16, 2025
| @@ -66,6 +67,10 @@ def get_chromium_files_for_validation() -> dict: | |||
| def find_use_counter_value( | |||
| body: dict, chromium_files_dict: dict) -> int | None: | |||
| """Find where the use counter is defined and return its value.""" | |||
| # Chromium file checks can be bypassed, but only in non-prod environments. | |||
There was a problem hiding this comment.
optional nit: Should this be factored and live in settings?
There was a problem hiding this comment.
This definitely should be - and I'll write an issue to make this change and land that in a separate PR
KyleJu
reviewed
Jan 16, 2025
KyleJu
reviewed
Jan 16, 2025
|
#4707 created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4428
This change adds a checkbox to the OT creation form in non-prod environments to skip the Chromium file checks. The server-side code is implemented so that a bypass request would always be ignored in prod environments.