Skip to content

Bump SharpCompress from 0.48.1 to 0.49.1#72

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.49.1
Open

Bump SharpCompress from 0.48.1 to 0.49.1#72
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/src/PSProxmoxVE.Core/main/SharpCompress-0.49.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Jun 2, 2026

Updated SharpCompress from 0.48.1 to 0.49.1.

Release notes

Sourced from SharpCompress's releases.

0.49.1

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.49.0...0.49.1

0.49.0

This should contain a lot of write async fixes and some breaking API changes that fix previous broke net48 usage

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.48.1...0.49.0

0.49.0-beta.140

What's Changed

Full Changelog: adamhathcock/sharpcompress@0.49.0-beta.136...0.49.0-beta.140

0.49.0-beta.136

What's Changed

New Contributors

Full Changelog: adamhathcock/sharpcompress@0.48.1...0.49.0-beta1

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

---
updated-dependencies:
- dependency-name: SharpCompress
  dependency-version: 0.49.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Jun 2, 2026
@dependabot dependabot Bot requested a review from GoodOlClint as a code owner June 2, 2026 12:48
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Jun 2, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Jun 2, 2026

Claude finished @dependabot[bot]'s task in 1m 13s —— View job


Review: SharpCompress 0.48.1 → 0.49.1

  • Gather context
  • Check SharpCompress usage in codebase for breaking changes
  • Assess 0.49.0 breaking API changes impact
  • Post review findings

Verdict: Safe to merge. This is a low-risk patch-level bump. Here's the analysis:

Breaking changes in 0.49.0 vs. codebase usage

SharpCompress usage in this repo is limited to a single call site: OvfMetadata.cs:89.

using var stream = File.OpenRead(tarPath);
using var reader = SharpCompress.Readers.ReaderFactory.OpenReader(stream, new SharpCompress.Readers.ReaderOptions());

IWriteableArchiveFactoryIWritableArchiveFactory rename — not used anywhere in this codebase. No impact.

LeaveStreamOpen default changed from true to false — this silently affects the code above. With 0.49.0+, when reader is disposed, it will now also close the underlying stream. The outer using var stream then disposes an already-closed FileStream, which is a safe no-op in .NET. No behavioral regression, but worth noting for future patterns.

0.49.1 bugfixes that benefit this codebase

  • "Fix tar archive enumeration after fully reading entry streams" (PR #1342) directly helps ExtractOvfFromTar. If an OVF entry stream is fully read and then the TAR reader attempts to advance to the next entry, prior versions could misbehave. This fix is a net improvement for OVA parsing.
  • "Close writable entry streams during async archive disposal" — not directly exercised by the current read-only usage.

CI

Build, Unit Tests, and Claude Code Review are all in progress at the time of this review. No failures observed.

Summary

No code changes are needed. The only SharpCompress API in use (ReaderFactory.OpenReader + sequential entry reading) is unaffected by breaking changes in 0.49.0. The 0.49.1 tar fix is a genuine improvement for the OVA import path. ✓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants