Adding a runtime selection dropdown into the editor

[BastiaanOlij]

Adding a dropdown (windows only) to the editor that allows us to select from different (known) runtimes:

The known runtimes are stored in runtimes.json in our addons folder so we can easily add more entries. On reading the JSON we will check if the paths to the runtime files exist and only offer those we find. We'll probably need to make it smarter to check the same path on different drives in case the user has decided to install Oculus/Steam on a D: or E: drive or something but that is for an enhancement PR.

If the current runtime is not found in the list, it is added (in editor only, the runtimes.json is not altered).

[BastiaanOlij]

This sort of works but we don't seem to have enough rights to update the registry key. Looking into that.

[BastiaanOlij]

Ok, so I couldn't get changing the registry entry through our plugin to work because of rights issues.

But with a pretty dirty hack I was able to get it to work with powershell.
The biggest issue is that I had to base64 encode the instructions. Powershell does not allow running scripts because somehow that is more unsafe, but it does allow us to base64 encode the script and just pass it through the command line. Go figure.
Problem is that powershell want the source data to be UTF16LE which Godot currently doesn't support as input to the base64 code. I cheated here, it'll work for our usecase. Burvzg added support to Godot 4, we'll need to look into backporting.

[BastiaanOlij]

@ChristophHaag I've completely changed this to be based on the environment variable.
It needs: godotengine/godot#46413
Should in theory work on Linux but as I can't test I don't know, it may have a problem with the ~ not being parsed to the current user folder.

[ChristophHaag]

With the home directory fix it works nicely on linux.

Short wishlist (maybe for the future):

• Show the full path somewhere in the ui (tooltip on the dropdownbox?)
• Persistently store the selected runtime
• Allow adding runtimes from the UI

[BastiaanOlij]

Short wishlist (maybe for the future):

I've added the tooltip but the other two I think we should do in new PRs.
One thing to discuss here is where we store the updated JSON. I consider the addons folder in a project to be read only because you need to be able to replace it with an updated version when we release a new version of the plugin.

[BastiaanOlij]

@ChristophHaag if you can have another quick look, I think this is ready to be merged. It works really well imho

[ChristophHaag]

looks good to me