[Performance]Investigate and improve videorendering#1039
Closed
ipavlidakis wants to merge 3 commits intodevelopfrom
Closed
[Performance]Investigate and improve videorendering#1039ipavlidakis wants to merge 3 commits intodevelopfrom
ipavlidakis wants to merge 3 commits intodevelopfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Failure to add the new IP will result in interrupted reviews. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Generated by 🚫 Danger |
| super.init(frame: frame) | ||
|
|
||
| // Subscribe to thermal state changes to adjust rendering performance. | ||
| cancellable = thermalStateObserver |
Contributor
There was a problem hiding this comment.
by deleting this, what would be the impact on the existing implementation?
ipavlidakis
force-pushed
the
iliaspavlidakis/ios-1377-performanceinvestigate-and-improve-videorendering
branch
from
23112d6 to
7ab1e89
Compare
# Conflicts: # StreamVideo.xcodeproj/project.pbxproj Update WebRTC Version Restructure DebugMenu options Apply videoRenderingOptions onAppear simplify videoRenderer and update webrtc version Update webrtc version Implement custom video capturing
ipavlidakis
force-pushed
the
iliaspavlidakis/ios-1377-performanceinvestigate-and-improve-videorendering
branch
from
7ab1e89 to
fac3c76
Compare
Collaborator
SDK Size
|
Public Interface+ public struct VideoRenderingOptions: Sendable, CustomStringConvertible
+
+ public let renderingBackend: RTCVideoRenderingBackend
+ public let bufferPolicy: RTCFrameBufferPolicy
+ public let maxInFlightFrames: Int
+ public let rotationOverride: RTCVideoRotation?
+ public var description: String
+
+
+ public init(renderingBackend: RTCVideoRenderingBackend = .default,bufferPolicy: RTCFrameBufferPolicy = .none,maxInFlightFrames: Int = 0,rotationOverride: RTCVideoRotation? = nil)
+ extension RTCFrameBufferPolicy: @retroactive CustomStringConvertible
+
+ public var description: String
+ extension RTCVideoRenderingBackend: @retroactive CustomStringConvertible
+
+ public var description: String
+ extension RTCVideoRotation: @retroactive CustomStringConvertible
+
+ public var description: String
public final class VideoConfig: Sendable
-
+ public let renderingOptions: VideoRenderingOptions
-
+
- public init(videoFilters: [VideoFilter] = [],noiseCancellationFilter: NoiseCancellationFilter? = nil,audioProcessingModule: AudioProcessingModule? = nil)
+
+ public init(renderingOptions: VideoRenderingOptions = .init(),videoFilters: [VideoFilter] = [],noiseCancellationFilter: NoiseCancellationFilter? = nil,audioProcessingModule: AudioProcessingModule? = nil)
- public class VideoRenderer: RTCMTLVideoView, @unchecked Sendable
+ public class VideoRenderer: RTCVideoRenderingView, @unchecked Sendable |
Collaborator
StreamVideo XCSize
|
Collaborator
StreamVideoSwiftUI XCSize
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-1377/performanceinvestigate-and-improve-videorendering-performance
🎯 Goal
Integrate:
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
imgimg🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)