Enable rendering backend in build script#9
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 133527bff2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fastlane/build_xcframework.sh
Outdated
| rtc_libvpx_build_vp9=true | ||
| stream_enable_rendering_backend=true |
There was a problem hiding this comment.
Because rtc_libvpx_build_vp9=true is missing a trailing \, the subsequent stream_enable_rendering_backend=true is executed as a separate shell assignment instead of being included in --extra-gn-args. When someone runs this script, the build command never receives the new GN flag, so the rendering backend stays disabled despite the change. Adding a line continuation to the previous line (or combining the args) keeps the flag in the GN args list.
Useful? React with 👍 / 👎.
ipavlidakis
deleted the
ipavlidakis/update-webrtc-build-to-include-stream_enable_rendering_backend
branch
2 participants
Related to GetStream/webrtc#70