Skip to content

Fix ChatChannelView keyboard background not using color from palette #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025
Merged

Fix ChatChannelView keyboard background not using color from palette #845

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1796263
Fix `ChatChannelView` keyboard background not using color from palette
nuno-vieira May 29, 2025
d88bbd0
Update CHANGELOG.md
nuno-vieira May 29, 2025
a30a580
Apply color to iPads as well
nuno-vieira May 30, 2025
5b16fb6
Fix E2E Test
nuno-vieira May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

# Upcoming

### 🔄 Changed
### 🐞 Fixed
- Fix `ChatChannelView` keyboard background not using color from palette [#845](https://github.com/GetStream/stream-chat-swiftui/pull/845)

# [4.79.0](https://github.com/GetStream/stream-chat-swiftui/releases/tag/4.79.0)
_May 29, 2025_
Expand Down
11 changes: 6 additions & 5 deletions Sources/StreamChatSwiftUI/ChatChannel/ChatChannelView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,13 +191,14 @@ public struct ChatChannelView<Factory: ViewFactory>: View, KeyboardReadable {
})
.background(
isIphone ?
Color.clear.background(
TabBarAccessor { _ in
self.tabBarAvailable = utils.messageListConfig.handleTabBarVisibility
}
)
Color(colors.background)
.ignoresSafeArea(.keyboard)
.allowsHitTesting(false)
: nil
).background(
TabBarAccessor { _ in
self.tabBarAvailable = utils.messageListConfig.handleTabBarVisibility
}
Copy link
Contributor

@laevandus laevandus May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this one also have the isIphone check?

Copy link
Member Author

@nuno-vieira nuno-vieira May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually removed the isIphone check on the color as well, to improve it on iPad too

)
.padding(.bottom, keyboardShown || !tabBarAvailable || generatingSnapshot ? 0 : bottomPadding)
.ignoresSafeArea(.container, edges: tabBarAvailable ? .bottom : [])
Expand Down
Loading