Fix ChatChannelView keyboard background not using color from palette
#845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
changed the title
SDK Size
|
nuno-vieira
commented
May 29, 2025
nuno-vieira
force-pushed
the
add/customizing-channel-view-background
branch
from
a0aee06 to
1796263
Compare
nuno-vieira
changed the title
nuno-vieira
changed the title
ChatChannelView keyboard background not using color from palette
laevandus
reviewed
May 30, 2025
Comment on lines
198
to
201
| ).background( | ||
| TabBarAccessor { _ in | ||
| self.tabBarAvailable = utils.messageListConfig.handleTabBarVisibility | ||
| } |
There was a problem hiding this comment.
Should this one also have the isIphone check?
There was a problem hiding this comment.
I actually removed the isIphone check on the color as well, to improve it on iPad too
martinmitrevski
approved these changes
May 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
IOS-852
🎯 Goal
🧪 Manual Testing Notes
N/A
☑️ Contributor Checklist
docs-contentrepo