Skip to content

[Feature] Allow customization of minOriginY in the initializer of ReactionsOverlayView #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

[Feature] Allow customization of minOriginY in the initializer of ReactionsOverlayView #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f66a60b
Allow customization of minOriginY in the initializer
sheep-q Mar 27, 2025
b17e114
add change log
sheep-q Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

# Upcoming

### ✅ Added
- Add `minOriginY` to the initializer of `ReactionsOverlayView` for better UI customization [#793](https://github.com/GetStream/stream-chat-swiftui/pull/793)
### 🔄 Changed

# [4.75.0](https://github.com/GetStream/stream-chat-swiftui/releases/tag/4.75.0)
Expand Down
10 changes: 6 additions & 4 deletions Sources/StreamChatSwiftUI/ChatChannel/Reactions/ReactionsOverlayView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public struct ReactionsOverlayView<Factory: ViewFactory>: View {
private var messageActionsCount: Int
private let paddingValue: CGFloat = 16
private let messageItemSize: CGFloat = 40
private let minOriginY: CGFloat
private var maxMessageActionsSize: CGFloat {
screenHeight / 3
}
Expand All @@ -39,6 +40,7 @@ public struct ReactionsOverlayView<Factory: ViewFactory>: View {
channel: ChatChannel,
currentSnapshot: UIImage,
messageDisplayInfo: MessageDisplayInfo,
minOriginY: CGFloat = 100,
bottomOffset: CGFloat = 0,
onBackgroundTap: @escaping () -> Void,
onActionExecuted: @escaping (MessageActionInfo) -> Void
Expand All @@ -51,6 +53,7 @@ public struct ReactionsOverlayView<Factory: ViewFactory>: View {
self.channel = channel
self.factory = factory
self.currentSnapshot = currentSnapshot
self.minOriginY = minOriginY
self.bottomOffset = bottomOffset
self.messageDisplayInfo = messageDisplayInfo
self.onBackgroundTap = onBackgroundTap
Expand Down Expand Up @@ -280,10 +283,9 @@ public struct ReactionsOverlayView<Factory: ViewFactory>: View {
let bottomPopupOffset =
messageDisplayInfo.showsMessageActions ? messageActionsSize : userReactionsPopupHeight
var originY = messageDisplayInfo.frame.origin.y
let minOrigin: CGFloat = 100
let maxOrigin: CGFloat = screenHeight - messageContainerHeight - bottomPopupOffset - minOrigin - bottomOffset
if originY < minOrigin {
originY = minOrigin
let maxOrigin: CGFloat = screenHeight - messageContainerHeight - bottomPopupOffset - minOriginY - bottomOffset
if originY < minOriginY {
originY = minOriginY
} else if originY > maxOrigin {
originY = maxOrigin
}
Expand Down
Loading