Skip to content

Conversation

sheep-q
Copy link
Contributor

@sheep-q sheep-q commented Mar 27, 2025

🔗 Issue Links

N/A

🎯 Goal

Be able to update min origin Y position of ReactionsOverlayView content for better UI flexibility instead of using a fixed default value.

📝 Summary

Allow minOriginY to be set through the initializer for better UI customization.

🛠 Implementation

Add minOriginY to the initializer of ReactionsOverlayView.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@sheep-q sheep-q requested a review from a team as a code owner March 27, 2025 10:00
Copy link
Contributor

@laevandus laevandus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good, we'll take this change in.

@laevandus laevandus merged commit bcf6563 into GetStream:develop Mar 27, 2025
5 of 9 checks passed
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants