Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ PR titles should follow the format below:
4. *types* other than `fix:` and `feat:` are allowed, for example **[@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional)** (based on the **[the Angular convention](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#-commit-message-guidelines)**) recommends `build:`, `chore:`, `ci:`, `docs:`, `style:`, `refactor:`, `perf:`, `test:`, and others.
5. *footers* other than `BREAKING CHANGE: <description>` may be provided and follow a convention similar to **[git trailer format](https://git-scm.com/docs/git-interpret-trailers)**.

### CHANGELOG.md Updates 📝

After making changes, please ensure you update the `CHANGELOG.md` file located in the root of each package you modified.

### Testing

At Stream, we value testing. Every PR should include passing tests for existing and new features. To run our test suite locally, you can use the following *Melos* command:
Expand All @@ -169,12 +173,6 @@ At Stream, we value testing. Every PR should include passing tests for existing
> melos run test:flutter
```

### Our Process

By default, our development branch is `develop`. Contributors should create new PRs based on `develop` when working on new features.

Develop is merged into master after the team performs various automated and QA tests on the branch. Master can be considered our stable branch, it represents the latest published release on pub.dev.

---

# Versioning Policy
Expand Down
6 changes: 6 additions & 0 deletions packages/stream_chat_flutter/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## Upcoming

🐞 Fixed

- Fixed mistakenly passing the hyperlink text to the `onLinkTap` callback instead of the actual `href`.

## 9.19.0

✅ Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,23 +47,23 @@ class StreamMessageText extends StatelessWidget {
messageTheme: messageTheme,
selectable: isDesktopDeviceOrWeb,
onTapLink: (
String link,
String text,
String? href,
String title,
) {
if (link.startsWith('@')) {
if (text.startsWith('@')) {
final mentionedUser = message.mentionedUsers.firstWhereOrNull(
(u) => '@${u.name}' == link,
(u) => '@${u.name}' == text,
);

if (mentionedUser == null) return;

onMentionTap?.call(mentionedUser);
} else {
} else if (href != null) {
if (onLinkTap != null) {
onLinkTap!(link);
onLinkTap!(href);
} else {
launchURL(context, link);
launchURL(context, href);
}
}
},
Expand Down
Loading