-
Notifications
You must be signed in to change notification settings - Fork 373
fix(ui): link text was passed to the onLinkTap callback instead of link href #2437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): link text was passed to the onLinkTap callback instead of link href #2437
Conversation
…d unrelevant info about the "develop" branch
WalkthroughRemoved development workflow guidance in CONTRIBUTING.md and updated message text handling in the Flutter message widget: renamed the Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as MessageText widget
participant Handler as onTapLink handler
participant Launcher as URL launcher
UI->>UI: User taps a link/text
alt text starts with '@' (mention)
UI->>Handler: onTapLink(text, ... ) %% mention case passes full text
else non-mention link
UI->>Handler: onLinkTap(text, href, ... ) %% pass href for URL actions
Handler-->>Launcher: request open href
Launcher-->>Handler: open result
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ptions to the changelog.md
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2437 +/- ##
=======================================
Coverage 63.99% 63.99%
=======================================
Files 415 415
Lines 25949 25949
=======================================
Hits 16606 16606
Misses 9343 9343 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CLA
Description of the pull request
The hyperlink text was mistakenly passed to the
onLinkTapcallback instead of the actualhref. Consequently, when a markdown hyperlink like[google link](https://google.com)was encountered, instead of directing the user to the intendedhttps://google.com, the browser was opened with the textgoogle linkitself.Summary by CodeRabbit
Documentation
Refactor