-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Implement SonarCloud #5511
Open
testableapple
wants to merge
8
commits into
develop
Choose a base branch
from
ci/sonar-cloud
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7239bcf
[CI] Implement SonarCloud
testableapple fc618c2
Ignore test/docs modules in sonar report
testableapple a852697
Remove 'stream-chat-android-pushprovider-firebase' from the list
testableapple 6b923c0
Update source matrix for impact analysis
testableapple 7c7364a
Quick fix
testableapple 7b1cb7a
Refactor sonar scripts
JcMinarro 93ba216
Remove uneeded test folder for our `stream-chat-android-client-test` …
JcMinarro be11c3d
Workaround to avoid issues with sonar plugin
JcMinarro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
if (!rootProject.ext.sonar.ignoreModules.contains(name)) { | ||
apply plugin: 'jacoco' | ||
apply plugin: "org.sonarqube" | ||
|
||
def isCore = (name == 'stream-chat-android-core') | ||
def testTask = isCore ? "test" : "testDebugUnitTest" | ||
def jacocoResults = "${buildDir}/reports/jacoco/report.xml" | ||
|
||
if (hasProperty('android')) { | ||
android { | ||
buildTypes { | ||
debug { | ||
testCoverageEnabled = true | ||
enableUnitTestCoverage = true | ||
enableAndroidTestCoverage true | ||
} | ||
} | ||
} | ||
} | ||
|
||
afterEvaluate { | ||
tasks.withType(Test).configureEach { | ||
jacoco.includeNoLocationClasses = true | ||
jacoco.excludes = ['jdk.internal.*'] | ||
} | ||
|
||
tasks.register("testCoverage", JacocoReport) { | ||
dependsOn testTask | ||
|
||
reports { | ||
xml.required.set(true) | ||
xml.outputLocation.set(file(jacocoResults)) | ||
} | ||
|
||
executionData.setFrom(fileTree(dir: buildDir, includes: [ | ||
"outputs/unit_test_code_coverage/debugUnitTest/testDebugUnitTest.exec", | ||
"jacoco/test.exec" | ||
])) | ||
|
||
def sources = isCore ? sourceSets.main.java.srcDirs : android.sourceSets.main.java.srcDirs | ||
sourceDirectories.setFrom(files(sources)) | ||
classDirectories.setFrom(files([ | ||
fileTree( | ||
dir: "${buildDir}/tmp/kotlin-classes/debug", | ||
excludes: rootProject.ext.sonar.excludeFilter | ||
), | ||
fileTree( | ||
dir: "${buildDir}/classes/kotlin/main", | ||
excludes: rootProject.ext.sonar.excludeFilter | ||
) | ||
])) | ||
} | ||
} | ||
|
||
sonarqube { | ||
properties { | ||
property "sonar.junit.reportPaths", "${buildDir}/test-results/${testTask}" | ||
property "sonar.coverage.jacoco.xmlReportPaths", jacocoResults | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
apply plugin: "org.sonarqube" | ||
|
||
ext.sonar = [ | ||
ignoreModules : [ | ||
'stream-chat-android-ai-assistant', | ||
'stream-chat-android-previewdata', | ||
'stream-chat-android-docs', | ||
'stream-chat-android-benchmark', | ||
'stream-chat-android-compose-sample', | ||
'stream-chat-android-e2e-test', | ||
'stream-chat-android-test', | ||
'stream-chat-android-ui-guides', | ||
'stream-chat-android-ui-components-sample', | ||
'stream-chat-android-client-test', | ||
'stream-chat-android-ui-uitests' | ||
], | ||
excludeFilter : [ | ||
'**/test/**', | ||
'**/androidTest/**', | ||
'**/R.class', | ||
'**/R2.class', | ||
'**/R$*.class', | ||
'**/BuildConfig.*', | ||
'**/Manifest*.*', | ||
'**/*Test*.*' | ||
] | ||
] | ||
|
||
ext.sonar.ignoreModules.each { | ||
ext.sonar.excludeFilter << "**/${it}/**" | ||
} | ||
|
||
sonarqube { | ||
properties { | ||
property("sonar.host.url", "https://sonarcloud.io") | ||
property("sonar.token", "${System.getenv("SONAR_TOKEN")}") | ||
property("sonar.organization", "getstream") | ||
property("sonar.projectKey", "GetStream_stream-chat-android") | ||
property("sonar.projectName", "stream-chat-android") | ||
property "sonar.java.coveragePlugin", "jacoco" | ||
property "sonar.sourceEncoding", "UTF-8" | ||
property "sonar.java.binaries", "${rootDir}/**/build/tmp/kotlin-classes/debug,${rootDir}/**/build/classes/kotlin/main" | ||
property "sonar.coverage.exclusions", rootProject.ext.sonar.excludeFilter | ||
} | ||
} |
1 change: 0 additions & 1 deletion
1
...t-android-client-test/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
stream-chat-android-client-test/src/test/resources/robolectric.properties
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are those environment variables needed even though the workflow has not changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just figured out that without this impact analysis does not work (for sonar coverage, snapshot tests and e2e tests), so I implemented these variables to other workflows as well as part of this PR even though it is not directly related.