[CI] Implement SonarCloud #5511
Conversation
testableapple
force-pushed
the
ci/sonar-cloud
branch
4 times, most recently
from
85dbeae to
813e204
Compare
testableapple
force-pushed
the
ci/sonar-cloud
branch
from
b1663f1 to
9cbeeaa
Compare
testableapple
force-pushed
the
ci/sonar-cloud
branch
from
9cbeeaa to
a8948b3
Compare
testableapple
force-pushed
the
ci/sonar-cloud
branch
from
a8948b3 to
d2c78cd
Compare
coverage.gradle
Outdated
| 'stream-chat-android-test', | ||
| 'stream-chat-android-ui-guides', | ||
| 'stream-chat-android-ui-components-sample', | ||
| 'stream-chat-android-pushprovider-firebase', |
There was a problem hiding this comment.
This module doesn't exist anymore
There was a problem hiding this comment.
All 4 modules? So it's safe to delete these lines, isn't it?
There was a problem hiding this comment.
stream-chat-android-pushprovider-firebase is not a module within Stream Chat SDK anymore.
It was extracted to a different repository: https://github.com/getstream/stream-android-push
There was a problem hiding this comment.
Oh, I see, only stream-chat-android-pushprovider-firebase then. Will remove it shortly 👍
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_PR_NUM: ${{ github.event.pull_request.number }} | ||
|
|
There was a problem hiding this comment.
Why are those environment variables needed even though the workflow has not changed?
There was a problem hiding this comment.
I just figured out that without this impact analysis does not work (for sonar coverage, snapshot tests and e2e tests), so I implemented these variables to other workflows as well as part of this PR even though it is not directly related.
fastlane/Fastfile
Outdated
| @@ -128,6 +134,7 @@ end | |||
|
|
|||
| private_lane :sources_matrix do | |||
| { | |||
| unit: ['stream-chat-android-client/', 'stream-chat-android-client-test/', 'stream-chat-android-compose/', 'stream-chat-android-core/', 'stream-chat-android-markdown-transformer/', 'stream-chat-android-offline/', 'stream-chat-android-state/', 'stream-chat-android-ui-common/', 'stream-chat-android-ui-components/', 'stream-chat-android-ui-utils/'], | |||
There was a problem hiding this comment.
What does this list represent?
There was a problem hiding this comment.
This list represents an impact analysis. If any of this paths were touched in the PR, then the check will be executed on CI. E.g.: if you updated README.md that sonar check won't be executed. But if you updated some file under stream-chat-android-client/ the check will be executed.
The unit key reflects unit tests, even though we do not use impact analysis for unit tests at the moment, I thought it still makes sense to use it for sonar analysis.
There was a problem hiding this comment.
Do we need to include stream-chat-android-client-test on this list??
This module is only used to provide "mother helpers" used on the rest of the tests modules, but it is not code perse.
There was a problem hiding this comment.
I think you are right. Let me create a separate list for the sonar source matrix
JcMinarro
force-pushed
the
ci/sonar-cloud
branch
from
cbdcee5 to
be11c3d
Compare
|
Resolve https://linear.app/stream/issue/AND-59
🎯 Goal
🛠 Implementation details
UnitTestsFilter.ktto include new commands☑️Contributor Checklist
General
Code & documentation
☑️Reviewer Checklist
🎉 GIF