Skip to content

✨ [FEAT] Make email optional in Report form (refs #4085) #4135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented May 28, 2024

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented May 28, 2024

Passing run #9211 ↗︎

0 22 0 0 Flakiness 0

Details:

Merge ae34ff9 into f34e2a0...
Project: Geotrek-admin Commit: 81c6b826ca ℹ️
Status: Passed Duration: 02:02 💡
Started: Jun 4, 2024 8:32 AM Ended: Jun 4, 2024 8:34 AM

Review all test suite changes for PR #4135 ↗︎

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (f34e2a0) to head (ae34ff9).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4135   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         267      267           
  Lines       20783    20794   +11     
=======================================
+ Hits        20447    20458   +11     
  Misses        336      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne force-pushed the feat_use_reports_from_admin branch 9 times, most recently from df496ca to cc7c10f Compare June 3, 2024 12:39
@Chatewgne Chatewgne requested a review from a team June 3, 2024 13:03
@Chatewgne Chatewgne force-pushed the feat_use_reports_from_admin branch from cc7c10f to 93b67cf Compare June 4, 2024 08:10
@Chatewgne Chatewgne force-pushed the feat_use_reports_from_admin branch from 93b67cf to ae34ff9 Compare June 4, 2024 08:18
@Chatewgne Chatewgne merged commit 2250ada into master Jun 4, 2024
20 checks passed
@Chatewgne Chatewgne deleted the feat_use_reports_from_admin branch June 4, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants