Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix parser translation field, add modified when new value is different from old value (for each language) #3418

Merged
merged 2 commits into from
Jan 20, 2023
Merged

🐛 Fix parser translation field, add modified when new value is different from old value (for each language) #3418

merged 2 commits into from
Jan 20, 2023

Conversation

LePetitTim
Copy link
Contributor

@LePetitTim LePetitTim commented Jan 19, 2023 •
edited
Loading

@cypress
Copy link

cypress bot commented Jan 19, 2023 •
edited
Loading


Test summary

24 • 0 • 0 • 0

Run details
Project Geotrek-admin
Status Passed
Commit 7a31469 ℹ️
Started Jan 20, 2023 9:10 AM
Ended Jan 20, 2023 9:13 AM
Duration 03:23 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Jan 19, 2023 •
edited
Loading

Codecov Report

Base: 98.23% // Head: 98.23% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a08e62e) compared to base (7623264).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3418   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         291      291           
  Lines       20789    20791    +2     
=======================================
+ Hits        20423    20425    +2     
  Misses        366      366
Impacted Files Coverage Δ
geotrek/common/parsers.py 93.09% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

camillemonchicourt
camillemonchicourt reviewed Jan 19, 2023
View reviewed changes
geotrek/trekking/tests/test_parsers.py Outdated
@@ -664,6 +664,13 @@ class TestApidaeTrekParser(ApidaeTrekParser):
selection_id = 654321


class TestApidaeTrekSameValueDifferentTraductionParser(TestApidaeTrekParser):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traduction or Translation ?

@LePetitTim LePetitTim force-pushed the fix_updated_parser_apidae branch 2 times, most recently from 31880ac to 4a36cc4 Compare January 19, 2023 17:05
@LePetitTim LePetitTim force-pushed the fix_updated_parser_apidae branch from 4a36cc4 to a08e62e Compare January 19, 2023 17:07
@submarcos
Copy link
Member

I don't understand the title, what is the goal ?

@LePetitTim LePetitTim changed the title 🐛 Add modified new value, old value 🐛 Fix parser translation field, add modified when new value is different from old value Jan 20, 2023
@LePetitTim LePetitTim changed the title 🐛 Fix parser translation field, add modified when new value is different from old value 🐛 Fix parser translation field, add modified when new value is different from old value (for each language) Jan 20, 2023
@LePetitTim LePetitTim requested a review from a team January 20, 2023 10:46
@LePetitTim LePetitTim merged commit ac2f5a2 into master Jan 20, 2023
@LePetitTim LePetitTim deleted the fix_updated_parser_apidae branch January 20, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camillemonchicourt camillemonchicourt camillemonchicourt left review comments

Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LePetitTim @submarcos @camillemonchicourt