Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix apidae parser should not update every time #3408

Merged
merged 6 commits into from
Jan 17, 2023

Conversation

LePetitTim
Copy link
Contributor

No description provided.

@LePetitTim LePetitTim requested review from marcantoinedupre and a team January 16, 2023 18:31
@cypress
Copy link

cypress bot commented Jan 16, 2023



Test summary

24 0 0 0


Run details

Project Geotrek-admin
Status Passed
Commit 868b95e ℹ️
Started Jan 17, 2023 2:06 PM
Ended Jan 17, 2023 2:09 PM
Duration 03:03 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@camillemonchicourt
Copy link
Member

What was the problem ?
And is it for all APIDAE parsers ?

@LePetitTim
Copy link
Contributor Author

What was the problem ? And is it for all APIDAE parsers ?

It's mostly for apidae parser, but i can improve other parsers.
Imports with this parser was always saying that there are some update which was not the case. I improved it.

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 98.23% // Head: 98.23% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4353021) compared to base (9ad3e59).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3408   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         291      291           
  Lines       20782    20789    +7     
=======================================
+ Hits        20416    20423    +7     
  Misses        366      366           
Impacted Files Coverage Δ
geotrek/common/parsers.py 93.07% <100.00%> (+0.03%) ⬆️
geotrek/trekking/parsers.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@camillemonchicourt
Copy link
Member

OK, thanks.
So it will update data in Geotrek (and their update_date), only if data have changed in Apidae.
Nice.

@LePetitTim LePetitTim changed the title fix: Fix apidae parser should not update every time 🐛 : Fix apidae parser should not update every time Jan 17, 2023
@LePetitTim LePetitTim changed the title 🐛 : Fix apidae parser should not update every time 🐛 Fix apidae parser should not update every time Jan 17, 2023
@LePetitTim LePetitTim force-pushed the fix_parser_apidae_update branch from 86485a8 to 4353021 Compare January 17, 2023 13:53
Copy link
Contributor

@marcantoinedupre marcantoinedupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants