Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in portfolio turnover calculation and test, Ledoit-Wolfe cov, base for Github actions #14

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

huuphuocle
Copy link

Hello,

Here are the details of my PR:

  • Some changes in portfolio.py: correct calculations, some perf improvement through binary search in portfolio list
  • Ledoit-Wolfe covariance: sklearn Ledoit-Wolfe shrinks only towards identity matrix it seems
  • some setup for a Github actions, a test class for portfolio.py and some changes in test_quadratic_program.py.
  • a minor fix in data_loader (because of the data format change in this PR: ✨ Standardize CSV File Formats for Consistency (#8) #10

Please let me know your feedback on this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant