Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Standardize CSV File Formats for Consistency (#8) #10

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

LitZeus
Copy link
Contributor

@LitZeus LitZeus commented Sep 26, 2024

✨ Fix CSV format inconsistency across data files (#8)

📝 Standardized all CSV files to use comma (,) as the delimiter.
🔧 Updated the following non-comma-separated CSV files for consistency:

  • data/NDDLWI.csv
  • data/msci_country_indices.csv

✅ Ensured format uniformity to match existing comma-separated files like SPTR.csv.

🔗 This resolves issue #8 where inconsistent CSV delimiters were causing problems in data processing.

@LitZeus LitZeus mentioned this pull request Sep 26, 2024
Copy link
Contributor

@vfisikop vfisikop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Since there is no CI yet for this repo, could you please confirm that tests are running correctly locally after your changes?

@LitZeus
Copy link
Contributor Author

LitZeus commented Oct 7, 2024

@vfisikop All the tests are running correctly in my local machine. No conflicts and errors are detected.

@vfisikop
Copy link
Contributor

@cbachela are you OK to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants