[Backport 3.x] [ISSUE #6551] Minor review of the current advanced resource workflow implementation… #6567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…implementation… (#6552) * Minor review of the current advanced resource workflow implementation #6551 * Fix tests on Travis * Fix logical errors on approval workflow * Fix tests on Travis * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit 9a1552a) * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit f23096c) * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit bfe51a7) * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit d9ec566) * Advanced workflow: filter actions stream returned to the users accordingly to their perms (cherry picked from commit 7f51346) * Advanced workflow: filter actions stream returned to the users accordingly to their perms * Add new settings from django-allauth 0.43.0 * Code styling alerts: remove unnecessary pass (cherry picked from commit 0676f6e) * Refreshing static libs (cherry picked from commit f27d0df) * Refreshing static libs (cherry picked from commit 5b166bc) * Advanced Workflow: Make sure the APIs counters are coherent with the visible resources (cherry picked from commit 1855d74) * Advanced Workflow: fix "request editing" action when published (cherry picked from commit 1041b12) * Advanced Workflow: fix "request editing" action when published -> send messages to group managers too (cherry picked from commit 5c93ef3) * Fix test on travis * Merge branch 'master' into adv_workflow_improvements
Codecov Report
@@ Coverage Diff @@
## 3.x #6567 +/- ##
===========================================
+ Coverage 41.90% 59.04% +17.14%
===========================================
Files 185 185
Lines 20509 20615 +106
Branches 3391 3437 +46
===========================================
+ Hits 8594 12172 +3578
+ Misses 11274 7370 -3904
- Partials 641 1073 +432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7de3a3c from #6552