-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6551] Minor review of the current advanced resource workflow implementation… #6552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
927c1dc
to
c7f651c
Compare
Codecov Report
@@ Coverage Diff @@
## master #6552 +/- ##
==========================================
+ Coverage 50.95% 58.94% +7.98%
==========================================
Files 187 187
Lines 20586 20692 +106
Branches 3396 3442 +46
==========================================
+ Hits 10489 12196 +1707
+ Misses 9186 7412 -1774
- Partials 911 1084 +173 |
This pull request introduces 1 alert when merging 00f4be1 into fdf60eb - view on LGTM.com new alerts:
|
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2020
…implementation… (#6552) * Minor review of the current advanced resource workflow implementation #6551 * Fix tests on Travis * Fix logical errors on approval workflow * Fix tests on Travis * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit 9a1552a) * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit f23096c) * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit bfe51a7) * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit d9ec566) * Advanced workflow: filter actions stream returned to the users accordingly to their perms (cherry picked from commit 7f51346) * Advanced workflow: filter actions stream returned to the users accordingly to their perms * Add new settings from django-allauth 0.43.0 * Code styling alerts: remove unnecessary pass (cherry picked from commit 0676f6e) * Refreshing static libs (cherry picked from commit f27d0df) * Refreshing static libs (cherry picked from commit 5b166bc) * Advanced Workflow: Make sure the APIs counters are coherent with the visible resources (cherry picked from commit 1855d74) * Advanced Workflow: fix "request editing" action when published (cherry picked from commit 1041b12) * Advanced Workflow: fix "request editing" action when published -> send messages to group managers too (cherry picked from commit 5c93ef3) * Fix test on travis * Merge branch 'master' into adv_workflow_improvements
afabiani
pushed a commit
that referenced
this pull request
Oct 25, 2020
…implementation… (#6552) (#6567) * Minor review of the current advanced resource workflow implementation #6551 * Fix tests on Travis * Fix logical errors on approval workflow * Fix tests on Travis * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit 9a1552a) * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit f23096c) * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit bfe51a7) * Advanced workflow: remove change_permissions to the owner if not a manager (cherry picked from commit d9ec566) * Advanced workflow: filter actions stream returned to the users accordingly to their perms (cherry picked from commit 7f51346) * Advanced workflow: filter actions stream returned to the users accordingly to their perms * Add new settings from django-allauth 0.43.0 * Code styling alerts: remove unnecessary pass (cherry picked from commit 0676f6e) * Refreshing static libs (cherry picked from commit f27d0df) * Refreshing static libs (cherry picked from commit 5b166bc) * Advanced Workflow: Make sure the APIs counters are coherent with the visible resources (cherry picked from commit 1855d74) * Advanced Workflow: fix "request editing" action when published (cherry picked from commit 1041b12) * Advanced Workflow: fix "request editing" action when published -> send messages to group managers too (cherry picked from commit 5c93ef3) * Fix test on travis * Merge branch 'master' into adv_workflow_improvements Co-authored-by: Alessio Fabiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: #6551
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.