Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6551] Minor review of the current advanced resource workflow implementation… #6552

Merged
merged 23 commits into from
Oct 25, 2020

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Oct 20, 2020

ISSUE: #6551

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani self-assigned this Oct 20, 2020
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 20, 2020
@afabiani afabiani force-pushed the adv_workflow_improvements branch from 927c1dc to c7f651c Compare October 21, 2020 10:00
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #6552 into master will increase coverage by 7.98%.
The diff coverage is 44.71%.

@@            Coverage Diff             @@
##           master    #6552      +/-   ##
==========================================
+ Coverage   50.95%   58.94%   +7.98%     
==========================================
  Files         187      187              
  Lines       20586    20692     +106     
  Branches     3396     3442      +46     
==========================================
+ Hits        10489    12196    +1707     
+ Misses       9186     7412    -1774     
- Partials      911     1084     +173     

@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2020

This pull request introduces 1 alert when merging 00f4be1 into fdf60eb - view on LGTM.com

new alerts:

  • 1 for Unnecessary pass

@afabiani afabiani added this to the 3.1 milestone Oct 22, 2020
@afabiani afabiani marked this pull request as ready for review October 23, 2020 18:10
@afabiani afabiani merged commit 7de3a3c into master Oct 25, 2020
@afabiani afabiani deleted the adv_workflow_improvements branch October 25, 2020 00:55
github-actions bot pushed a commit that referenced this pull request Oct 25, 2020
…implementation… (#6552)

* Minor review of the current advanced resource workflow implementation #6551

* Fix tests on Travis

* Fix logical errors on approval workflow

* Fix tests on Travis

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit 9a1552a)

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit f23096c)

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit bfe51a7)

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit d9ec566)

* Advanced workflow: filter actions stream returned to the users accordingly to their perms

(cherry picked from commit 7f51346)

* Advanced workflow: filter actions stream returned to the users accordingly to their perms

* Add new settings from django-allauth 0.43.0

* Code styling alerts: remove unnecessary pass

(cherry picked from commit 0676f6e)

* Refreshing static libs

(cherry picked from commit f27d0df)

* Refreshing static libs

(cherry picked from commit 5b166bc)

* Advanced Workflow: Make sure the APIs counters are coherent with the visible resources

(cherry picked from commit 1855d74)

* Advanced Workflow: fix "request editing" action when published

(cherry picked from commit 1041b12)

* Advanced Workflow: fix "request editing" action when published -> send messages to group managers too

(cherry picked from commit 5c93ef3)

* Fix test on travis

* Merge branch 'master' into adv_workflow_improvements
afabiani pushed a commit that referenced this pull request Oct 25, 2020
…implementation… (#6552) (#6567)

* Minor review of the current advanced resource workflow implementation #6551

* Fix tests on Travis

* Fix logical errors on approval workflow

* Fix tests on Travis

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit 9a1552a)

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit f23096c)

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit bfe51a7)

* Advanced workflow: remove change_permissions to the owner if not a manager

(cherry picked from commit d9ec566)

* Advanced workflow: filter actions stream returned to the users accordingly to their perms

(cherry picked from commit 7f51346)

* Advanced workflow: filter actions stream returned to the users accordingly to their perms

* Add new settings from django-allauth 0.43.0

* Code styling alerts: remove unnecessary pass

(cherry picked from commit 0676f6e)

* Refreshing static libs

(cherry picked from commit f27d0df)

* Refreshing static libs

(cherry picked from commit 5b166bc)

* Advanced Workflow: Make sure the APIs counters are coherent with the visible resources

(cherry picked from commit 1855d74)

* Advanced Workflow: fix "request editing" action when published

(cherry picked from commit 1041b12)

* Advanced Workflow: fix "request editing" action when published -> send messages to group managers too

(cherry picked from commit 5c93ef3)

* Fix test on travis

* Merge branch 'master' into adv_workflow_improvements

Co-authored-by: Alessio Fabiani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant