Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #5049] Thumbnails are generated with a point style for line/polygon layers #5116

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Oct 25, 2019

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani requested a review from capooti October 25, 2019 09:50
@afabiani afabiani self-assigned this Oct 25, 2019
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 25, 2019
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #5116 into master will increase coverage by 0.09%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #5116      +/-   ##
==========================================
+ Coverage    53.6%   53.69%   +0.09%     
==========================================
  Files         185      185              
  Lines       20791    20800       +9     
  Branches     3301     3306       +5     
==========================================
+ Hits        11144    11169      +25     
+ Misses       8637     8622      -15     
+ Partials     1010     1009       -1

Copy link
Member

@capooti capooti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afabiani for adding the tests! great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thumbnails are generated with a point style for line/polygon layers
2 participants