Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails are generated with a point style for line/polygon layers #5049

Closed
capooti opened this issue Oct 16, 2019 · 1 comment · Fixed by #5116
Closed

Thumbnails are generated with a point style for line/polygon layers #5049

capooti opened this issue Oct 16, 2019 · 1 comment · Fixed by #5116
Assignees
Labels
needs further investigation Issue or reason for specific behaviour needs further investigation

Comments

@capooti
Copy link
Member

capooti commented Oct 16, 2019

Expected Behavior

A thumbnail for a line or polygon layer should be generated with a correct line or polygon style.

Actual Behavior

Under some circumstances (large GS with many layers?) I have seen this bug happening on different instances.

Steps to Reproduce the Problem

Not reproducible using a standard GeoNode installation.

Specifications

  • GeoNode version: master
  • Installation method (manual, GeoNode Docker, SPCGeoNode Docker): manual
  • Platform: Ubuntu
  • Additional details:
capooti added a commit to capooti/geonode that referenced this issue Oct 16, 2019
@capooti capooti self-assigned this Oct 16, 2019
@capooti capooti added the minor A low priority issue which might affect only some users and /or not the main functionality label Oct 16, 2019
@capooti capooti added this to the 2.10.1 milestone Oct 17, 2019
@capooti capooti added major A high priority issue which might affect a lot of people or large parts of the codebase and removed minor A low priority issue which might affect only some users and /or not the main functionality labels Oct 17, 2019
capooti added a commit to capooti/geonode that referenced this issue Oct 18, 2019
@afabiani afabiani added needs further investigation Issue or reason for specific behaviour needs further investigation and removed major A high priority issue which might affect a lot of people or large parts of the codebase labels Oct 22, 2019
@afabiani afabiani removed this from the 2.10.1 milestone Oct 22, 2019
@afabiani
Copy link
Member

@capooti so, I took some time to try to understand the issue and the solution you are going to implement.

It seems to me that the PR actually is not related to the problem you are describing.

The thumbnails are generated using the current default style set into GeoServer, therefore this issue is a side effect of the fact that the layer in GeoServer is not correctly configured.

Most probably, by just using the "Manage Style" function and setting the correct default style, fixes the issue.

image

On the other side, it could be a "feature" to allow the thumbnail generator to take the "styles" parameter. But this topic must be further investigated.
I really don't think it is a good solution to just inject a default style to the request.
We could envisage a way to let the user select the style he would like to use to generate the thumbnail.

That said, this is not a "Major" issue and I disagree to include this one into the 2.10.1 release.

afabiani pushed a commit that referenced this issue Oct 25, 2019
[Backport 2.10.1] [Fixes #5049] Thumbnails are generated with a point style for line/polygon layers
afabiani pushed a commit that referenced this issue Oct 25, 2019
[Backport 2.10.x] [Fixes #5049] Thumbnails are generated with a point style for line/polygon layers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs further investigation Issue or reason for specific behaviour needs further investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants