Consolidate nuspec into csproj #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most information from nuspec can be specified in the csproj. This has the benefit that all information is located in a single place and that previously duplicated information can no longer be out of sync. Currently release notes and package dependencies are out of sync. I've added the following: * Xavier Fischer as Author. * Referred MIT license directly instead of throught `LICENSE.MD` * link to github project page * link to git repository csproj does not support the concepts of `<owners>` and `<language>` so I've left them out. The following tags are automatically inferred: * `<id>` from project name * `requireLicenseAcceptance` defaults to `false` * `AssemblyVersion` is `$(Version).0` Some good resources: * https://github.com/NuGet/Home/wiki/Adding-nuget-pack-as-a-msbuild-target * https://andrewlock.net/version-vs-versionsuffix-vs-packageversion-what-do-they-all-mean/
|
A big thank you @jnyrup ! Very good resources indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most information from nuspec can be specified in the csproj.
This has the benefit that all information is located in a single place and that previously duplicated information can no longer be out of sync.
Currently release notes and package dependencies are out of sync.
I've added the following:
LICENSE.MDcsproj does not support the concepts of
<owners>and<language>so I've left them out.The following tags are automatically inferred:
<id>from project namerequireLicenseAcceptancedefaults tofalseAssemblyVersionis$(Version).0Some good resources:
This fixes #134